HAR-9460 - handle alternate content node#486
Merged
harbournick merged 1 commit intomainfrom May 1, 2025
Merged
Conversation
artem-harbour
changed the title
artem-harbour
force-pushed
the
artem-HAR-9460-v2
branch
from
bb3c70b to
3a9c0cb
Compare
artem-harbour
force-pushed
the
artem-HAR-9460-v2
branch
from
3a9c0cb to
093f588
Compare
artem-harbour
changed the title
artem-harbour
commented
Apr 30, 2025
| element.style.paddingLeft = pageMargins.left + 'in'; | ||
| element.style.paddingRight = pageMargins.right + 'in'; | ||
| element.style.boxSizing = 'border-box'; | ||
| element.style.isolation = 'isolate'; // to create new stacking context. |
Contributor
Author
There was a problem hiding this comment.
https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_positioned_layout/Stacking_context
To make z-index: -1 work for the element. This is probably a safer way than assigning z-index to the editor.
Contributor
Author
|
FYI @harbournick - this is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes from this PR are used here as a basis.
#478