Skip to content

HAR-9647 - improve styles encapsulation#504

Merged
harbournick merged 2 commits intomainfrom
artem-HAR-9647-v1
May 18, 2025
Merged

HAR-9647 - improve styles encapsulation#504
harbournick merged 2 commits intomainfrom
artem-HAR-9647-v1

Conversation

@artem-harbour
Copy link
Copy Markdown
Contributor

@artem-harbour artem-harbour commented May 15, 2025

Note: see comment in linear ticket.

@artem-harbour artem-harbour self-assigned this May 15, 2025
@artem-harbour artem-harbour added the don't merge Don't merge yet label May 15, 2025
@artem-harbour artem-harbour changed the title [WIP] HAR-9647 - improve styles encapsulation HAR-9647 - improve styles encapsulation May 16, 2025
</template>

<style lang="postcss">
/** Global styles */
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the changes from this commit, which also raises issues.

Use dynamic import for pdf js styles
f6ab36e

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artem-harbour artem-harbour added ready for review and removed don't merge Don't merge yet labels May 16, 2025
@artem-harbour artem-harbour marked this pull request as ready for review May 16, 2025 14:54
@artem-harbour artem-harbour requested a review from harbournick May 16, 2025 14:54
Copy link
Copy Markdown
Collaborator

@harbournick harbournick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harbournick harbournick merged commit 4bf3b94 into main May 18, 2025
5 of 6 checks passed
@harbournick harbournick deleted the artem-HAR-9647-v1 branch May 18, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants