Merged
Conversation
chittolinag
reviewed
May 19, 2025
chittolinag
requested changes
May 20, 2025
Contributor
chittolinag
left a comment
chittolinag
left a comment
There was a problem hiding this comment.
@johanneswilm thanks a lot for the help here! I know it's not a trivial task to add types for a somewhat unfamiliar codebase... I added a few comments and requested some changes - please let us know if you have any questions.
@harbournick cc ^
Collaborator
|
@johanneswilm thanks for the great work here! I went through and resolved any comments no longer needed. Could you please resolve the merge conflict and resolve the final 5 comments? Thank you! |
Contributor
Author
|
will do |
Contributor
Author
|
@harbournick @chittolinag I have resolved the remaining issues - have a look though before merging as some of the solutions I used were different from what was initially suggested. |
chittolinag
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First attempt to add jsdoc annotations to Editor.js and super-toolbar.js.
In some cases, I was not entirely sure, for example when arguments are not in use anywhere in a given method like here:
https://github.com/Harbour-Enterprises/SuperDoc/compare/main...johanneswilm:SuperDoc:add-jsdoc-annotations?expand=1#diff-cf578a6f4b5c61edc4820b992b2ecf85ac935fd7c6019e26b6b59076c7f0067fL563-L566