HAR-9668 Fix issue with inability to open the document after export#518
Merged
harbournick merged 3 commits intomainfrom May 22, 2025
Merged
HAR-9668 Fix issue with inability to open the document after export#518harbournick merged 3 commits intomainfrom
harbournick merged 3 commits intomainfrom
Conversation
Contributor
artem-harbour
left a comment
artem-harbour
left a comment
There was a problem hiding this comment.
These changes look good to me, although I'm not sure how this will affect import/export of annotations. Before merging, could you test these changes locally with full flow in webapp?
Contributor
Author
|
@artem-harbour @harbournick tested it within Webapp and add a couple of more fixes. Was able to download and open agreement with html annotations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue appeared due to exporting sdt annotations together with text nodes in one paragraph within table cell.
Word cannot open a .docx file when a <w:sdt> (Structured Document Tag) and a regular text run (<w:r>) are siblings directly inside a single paragraph (<w:p>) inside a table cell (<w:tc>) due to a strict XML schema rule in WordprocessingML. This structure violates the expected content model for Word, even though it's technically allowed by the Open XML standard.