[WIP] HAR-9550 - floating page breaks#529
Closed
artem-harbour wants to merge 1 commit intodevelopfrom
Closed
Conversation
artem-harbour
changed the title
harbournick
reviewed
Jun 5, 2025
Collaborator
harbournick
left a comment
harbournick
left a comment
There was a problem hiding this comment.
@artem-harbour thanks for working on this, sorry for the delay here. I think the approach works well - as well as we can with the current implementation. The flickering is very minimal and there could be optimizations made there later if needed. I would say the result here is miles better than the current result so we should move forward with this until a larger v2 of pagination
artem-harbour
changed the title
artem-harbour
force-pushed
the
artem-HAR-9550
branch
4 times, most recently
from
00f78f2 to
5f51f2b
Compare
artem-harbour
force-pushed
the
artem-HAR-9550
branch
from
5f51f2b to
c88cd34
Compare
Contributor
Author
|
Closing this one as I found a better solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE!