Skip to content

HAR-9795 Accessibility: ARIA infrastructure#557

Merged
harbournick merged 3 commits intodevelopfrom
har-9795_aria-infra
Jun 5, 2025
Merged

HAR-9795 Accessibility: ARIA infrastructure#557
harbournick merged 3 commits intodevelopfrom
har-9795_aria-infra

Conversation

@VladaHarbour
Copy link
Copy Markdown
Contributor

Tested with axe Devtools(chrome). According to the result of inspection I had to remove attributes from some prosemirror nodes (like paragraph, content, tab).
Also it seems like aria-multilined is only supported by textarea
Screenshot 2025-06-05 at 16 09 27

Comment thread packages/super-editor/src/components/toolbar/defaultItems.js Outdated
Comment thread packages/super-editor/src/components/toolbar/defaultItems.js Outdated
Comment thread packages/super-editor/src/components/toolbar/defaultItems.js Outdated
Comment thread packages/super-editor/src/components/toolbar/defaultItems.js Outdated
Copy link
Copy Markdown
Contributor

@artem-harbour artem-harbour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to fix a couple of typos.

@harbournick harbournick changed the base branch from main to develop June 5, 2025 23:12
Copy link
Copy Markdown
Collaborator

@harbournick harbournick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harbournick harbournick merged commit 093c9ea into develop Jun 5, 2025
3 checks passed
@harbournick harbournick deleted the har-9795_aria-infra branch June 5, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants