Skip to content

Fix: wp anchor image export and content types main #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edoversb merged 3 commits into from
Jul 25, 2025
Merged

Fix: wp anchor image export and content types main #706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b16f183
fix: filter out .rels files from header/footer processing
harbournick Jul 25, 2025
fd48db4
fix: prevent footer/header rels files from being added to content typ…
harbournick Jul 25, 2025
0142642
chore: add comment to .rels fix
harbournick Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/super-editor/src/core/DocxZipper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,9 @@ class DocxZipper {
}

Object.keys(docx.files).forEach((name) => {
if (!name.includes('header') && !name.includes('footer')) return;
// Important: We need to filter out .rels files - they should not be included in content types
// Otherwise this generates MS word validation error
if (name.includes('.rels') || (!name.includes('header') && !name.includes('footer'))) return;
const hasExtensible = types.elements?.some(
(el) => el.name === 'Override' && el.attributes.PartName === `/${name}`,
);
Expand Down
9 changes: 8 additions & 1 deletion packages/super-editor/src/core/super-converter/exporter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1922,6 +1922,13 @@ function translateImageNode(params, imageSize) {
name: 'wp:wrapTopAndBottom',
});
}

// Important: wp:anchor will break if no wrapping is specified. We need to use wrapNone.
if (attrs.isAnchor && !wrapProp.length) {
wrapProp.push({
name: 'wp:wrapNone',
});
}
}

const drawingXmlns = 'http://schemas.openxmlformats.org/drawingml/2006/main';
Expand Down Expand Up @@ -2070,7 +2077,7 @@ function translateImageNode(params, imageSize) {
},
[],
);

return textNode;
}

Expand Down
Loading