Skip to content

refactor: add fallback logging for init routine #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harbournick merged 1 commit into from
Aug 4, 2025
Merged

refactor: add fallback logging for init routine #728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions packages/superdoc/src/core/SuperDoc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ export class SuperDoc extends EventEmitter {

// @ts-ignore
this.version = __APP_VERSION__;
console.debug('🦋 [superdoc] Using SuperDoc version:', this.version);
this.#log('🦋 [superdoc] Using SuperDoc version:', this.version);

this.superdocId = config.superdocId || uuidv4();
this.colors = this.config.colors;
Expand Down Expand Up @@ -478,8 +478,8 @@ export class SuperDoc extends EventEmitter {
this.emit('sidebar-toggle', isOpened);
}

log(...args) {
console.debug('🦋 🦸‍♀️ [superdoc]', ...args);
#log(...args) {
(console.debug ? console.debug : console.log)('🦋 🦸‍♀️ [superdoc]', ...args);
}

/**
Expand Down Expand Up @@ -558,7 +558,7 @@ export class SuperDoc extends EventEmitter {
*/
addCommentsList(element) {
if (!this.config?.modules?.comments || this.config.role === 'viewer') return;
console.debug('🦋 [superdoc] Adding comments list to:', element);
this.#log('🦋 [superdoc] Adding comments list to:', element);
if (element) this.config.modules.comments.element = element;
this.commentsList = new SuperComments(this.config.modules?.comments, this);
if (this.config.onCommentsListChange) this.config.onCommentsListChange({ isRendered: true });
Expand Down Expand Up @@ -718,7 +718,7 @@ export class SuperDoc extends EventEmitter {
lockSuperdoc(isLocked = false, lockedBy) {
this.isLocked = isLocked;
this.lockedBy = lockedBy;
console.debug('🦋 [superdoc] Locking superdoc:', isLocked, lockedBy, '\n\n\n');
this.#log('🦋 [superdoc] Locking superdoc:', isLocked, lockedBy, '\n\n\n');
this.emit('locked', { isLocked, lockedBy });
}

Expand Down Expand Up @@ -801,7 +801,7 @@ export class SuperDoc extends EventEmitter {
* @returns {Promise<void>} Resolves when all documents have saved
*/
async #triggerCollaborationSaves() {
console.debug('🦋 [superdoc] Triggering collaboration saves');
this.#log('🦋 [superdoc] Triggering collaboration saves');
return new Promise((resolve, reject) => {
this.superdocStore.documents.forEach((doc) => {
this.pendingCollaborationSaves = 0;
Expand Down Expand Up @@ -832,9 +832,9 @@ export class SuperDoc extends EventEmitter {
// this.exportEditorsToDOCX(),
];

console.debug('🦋 [superdoc] Saving superdoc');
this.#log('🦋 [superdoc] Saving superdoc');
const result = await Promise.all(savePromises);
console.debug('🦋 [superdoc] Save complete:', result);
this.#log('🦋 [superdoc] Save complete:', result);
return result;
}

Expand All @@ -847,7 +847,7 @@ export class SuperDoc extends EventEmitter {
return;
}

this.log('[superdoc] Unmounting app');
this.#log('[superdoc] Unmounting app');

this.config.socket?.cancelWebsocketRetry();
this.config.socket?.disconnect();
Expand Down
Loading