HAR-10241 - fix: list items#771
Merged
harbournick merged 1 commit intodevelopfrom Aug 13, 2025
Merged
Conversation
artem-harbour
commented
Aug 13, 2025
artem-harbour
commented
Aug 13, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes list item styling and behavior issues by implementing proper marker alignment based on text justification, adding line height support, and fixing text content handling in list splitting operations.
- Implements marker positioning logic that handles both left and right text alignment
- Adds line height extraction and application from text style marks
- Removes marks length condition from list item splitting logic
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| ListItemNodeView.js | Adds marker positioning constants, line height support, and refactors marker positioning with justification-aware handlers |
| list-numbering-helpers.js | Extracts level justification data from list definitions |
| splitListItem.js | Simplifies text content handling by removing marks length conditions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes - HAR-10241, HAR-10159 and HAR-10167.
See comment in linear (HAR-10241) before merging.