Skip to content

chore: add constants in node view, lint and format#772

Merged
harbournick merged 1 commit intodevelopfrom
fix/minor-cleanup-node-view
Aug 13, 2025
Merged

chore: add constants in node view, lint and format#772
harbournick merged 1 commit intodevelopfrom
fix/minor-cleanup-node-view

Conversation

@harbournick
Copy link
Copy Markdown
Collaborator

No description provided.

@harbournick harbournick requested a review from Copilot August 13, 2025 20:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds constants for improved code maintainability, applies linting fixes, and performs code formatting. The changes focus on replacing magic numbers and strings with named constants and cleaning up unused variables.

  • Extracts magic numbers and default values into named constants for better readability
  • Removes unused variable declaration to clean up code
  • Simplifies error handling by removing unused error parameter

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
ListItemNodeView.js Adds constants for font conversion factor and default values, improves marker width calculation function
runNodeImporter.js Removes unused attributes variable from destructuring assignment

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread packages/super-editor/src/extensions/list-item/ListItemNodeView.js
@harbournick harbournick merged commit c591032 into develop Aug 13, 2025
7 checks passed
@harbournick harbournick deleted the fix/minor-cleanup-node-view branch August 13, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants