Skip to content

fix(paragraph): preserve empty text with spaces nodes #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harbournick merged 2 commits into from
Aug 15, 2025
Merged

fix(paragraph): preserve empty text with spaces nodes #775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b7674b
fix: preserve empty spaces in XML parsing and handle temporary wrappe…
Aug 14, 2025
7e354c4
Merge remote-tracking branch 'origin/develop' into fix/sig-block
Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/super-editor/src/core/super-converter/SuperConverter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,9 @@ class SuperConverter {
}

parseXmlToJson(xml) {
return JSON.parse(xmljs.xml2json(xml, null, 2));
// We need to preserve nodes with xml:space="preserve" and only have empty spaces
const newXml = xml.replace(/(<w:t xml:space="preserve">)(\s+)(<\/w:t>)/g, '$1[[sdspace]]$2[[sdspace]]$3');
return JSON.parse(xmljs.xml2json(newXml, null, 2));
}

static getStoredSuperdocVersion(docx) {
Expand Down
6 changes: 5 additions & 1 deletion packages/super-editor/src/core/super-converter/v2/importer/textNodeImporter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ export const handleTextNode = (params) => {

// Text nodes have no children. Only text, and there should only be one child
let text;
if (elements.length === 1) text = elements[0].text;
if (elements.length === 1) {
text = elements[0].text;
// Handle the removal of a temporary wrapper that we added to preserve empty spaces
text = text.replace(/\[\[sdspace\]\]/g, '');
}
// Word sometimes will have an empty text node with a space attribute, in that case it should be a space
else if (!elements.length && 'attributes' in node && node.attributes['xml:space'] === 'preserve') {
text = ' ';
Expand Down
Loading