Skip to content

feat: added duration to transaction callback#778

Merged
harbournick merged 3 commits intodevelopfrom
feat/transaction-duration
Aug 15, 2025
Merged

feat: added duration to transaction callback#778
harbournick merged 3 commits intodevelopfrom
feat/transaction-duration

Conversation

@chittolinag
Copy link
Copy Markdown
Contributor

Added transaction duration to allow us to measure the performance of SuperDoc interactions.

@harbournick harbournick requested a review from Copilot August 15, 2025 19:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds transaction duration tracking to the SuperDoc editor to enable performance monitoring of editor interactions. The changes introduce a duration measurement system that captures the time taken for each transaction to complete.

  • Added onTransaction callback configuration to SuperDoc
  • Implemented transaction duration measurement in the Editor class
  • Connected the transaction callback through the SuperDoc Vue component

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/superdoc/src/core/SuperDoc.js Added onTransaction callback configuration option
packages/superdoc/src/SuperDoc.vue Implemented transaction callback handler to pass through duration data
packages/super-editor/src/core/Editor.js Added duration measurement using Date.now() around transaction processing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread packages/super-editor/src/core/Editor.js
Copy link
Copy Markdown
Collaborator

@harbournick harbournick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny change!

Comment thread packages/superdoc/src/core/SuperDoc.js
Copy link
Copy Markdown
Collaborator

@harbournick harbournick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harbournick harbournick merged commit 4cb21a3 into develop Aug 15, 2025
7 checks passed
@harbournick harbournick deleted the feat/transaction-duration branch August 15, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants