Skip to content

feat: programmatic text selection example#792

Merged
harbournick merged 1 commit intodevelopfrom
programmatic-text-selection-example
Aug 22, 2025
Merged

feat: programmatic text selection example#792
harbournick merged 1 commit intodevelopfrom
programmatic-text-selection-example

Conversation

@mattConnHarbour
Copy link
Copy Markdown
Contributor

No description provided.

@mattConnHarbour mattConnHarbour force-pushed the programmatic-text-selection-example branch from 1d2e05c to 59ac5cf Compare August 20, 2025 16:56
Copy link
Copy Markdown
Collaborator

@harbournick harbournick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments, and let's please add a README.md file for people browsing the examples folder

Comment thread examples/programmatic-text-selection/src/App.jsx Outdated
Comment thread examples/programmatic-text-selection/src/App.jsx Outdated
@harbournick
Copy link
Copy Markdown
Collaborator

@mattConnHarbour just a reminder on this one - very minor comments before we can merge

@mattConnHarbour
Copy link
Copy Markdown
Contributor Author

mattConnHarbour commented Aug 22, 2025

@mattConnHarbour just a reminder on this one - very minor comments before we can merge

Thanks for the reminder! I'll wrap this up before EOD.

@mattConnHarbour mattConnHarbour force-pushed the programmatic-text-selection-example branch 2 times, most recently from 71f4abe to d8e80f3 Compare August 22, 2025 19:48
Copy link
Copy Markdown
Collaborator

@harbournick harbournick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think you missed this comment: #792 (review)

Let's add that then we're good to go

@mattConnHarbour mattConnHarbour force-pushed the programmatic-text-selection-example branch from 4831b5c to a9fcac1 Compare August 22, 2025 22:37
Copy link
Copy Markdown
Collaborator

@harbournick harbournick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harbournick harbournick merged commit b06e394 into develop Aug 22, 2025
7 checks passed
@harbournick harbournick deleted the programmatic-text-selection-example branch August 22, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants