Skip to content

Draft: fix(underline): underline handling that allows for run underline to o…#799

Closed
palmer-cl wants to merge 1 commit intodevelopfrom
fix/cl-trms/formatting
Closed

Draft: fix(underline): underline handling that allows for run underline to o…#799
palmer-cl wants to merge 1 commit intodevelopfrom
fix/cl-trms/formatting

Conversation

@palmer-cl
Copy link
Copy Markdown
Collaborator

  • Allows for override of paragraph underlines with run underlines that contain no w:val.

Additional context based on my findings:

  • Word may have <w:u> tags but does not express them as underlines if they have no val property
  • The document sent via email has mostly all of the text underlined, but not expressed because at the run level the underlines have no val=single or any other type of underline
  • So if on the paragraph you have <w:u val=single> but on a run you then have <w:u color='fff'> this underline should not be expressed

Pay close attention to:

  • we swap the order of mark processing to process paragraph first, then run marks so that the run marks take precendence. I didn't see any ramifications but good to double check this.

Example p tag:

image

@palmer-cl palmer-cl changed the title fix(underline): underline handling that allows for run underline to o… Draft: fix(underline): underline handling that allows for run underline to o… Aug 22, 2025
@palmer-cl
Copy link
Copy Markdown
Collaborator Author

Closing this going to take a different approach

@palmer-cl palmer-cl closed this Aug 26, 2025
@caio-pizzol caio-pizzol deleted the fix/cl-trms/formatting branch September 1, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant