Feature: list command upgrades, toggle list fix, prep for run node#826
Merged
Feature: list command upgrades, toggle list fix, prep for run node#826
Conversation
Collaborator
harbournick
commented
Aug 30, 2025
harbournick
commented
- Fixes for list commands
- Fixes for toggle list with single and multiple nodes back-and-forth
- Adds tests to list commands
- Adds types to list commands
- Prepares lists to work with run node
harbournick
force-pushed
the
feat/list-cmds-upgrades-tests
branch
from
40fae73 to
12a51e6
Compare
harbournick
force-pushed
the
feat/list-cmds-upgrades-tests
branch
from
12a51e6 to
0613ea6
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request implements significant improvements to list command functionality, toggle list fixes, and enhanced testing. The changes focus on making list toggling more robust, handling single and multiple node selections, and laying groundwork for run node compatibility.
- Upgraded toggleList command with proper type conversion, selection preservation, and multi-paragraph handling
- Fixed toggle list functionality for converting between list types and unwrapping lists
- Added comprehensive test coverage for list commands with proper mocking infrastructure
Reviewed Changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| toggleList.js | Complete rewrite with improved logic for list toggling, type conversion, and selection handling |
| toggleList.test.js | Comprehensive test suite covering various toggle scenarios |
| splitListItem.js | Simplified logic for splitting list items with better handling of multi-paragraph cases |
| deleteSelection.js | Extracted helper functions into separate modules for better organization |
| findParentNode.js | Added TypeScript annotations and improved documentation |
| Various helper files | New utility functions for list operations with comprehensive test coverage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Collaborator
Author
|
🎉 This PR is included in version 0.16.0-next.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.