Skip to content

Fix: list outdent and lint#855

Merged
harbournick merged 2 commits into
mainfrom
fix/list-outdent-and-lint
Sep 2, 2025
Merged

Fix: list outdent and lint#855
harbournick merged 2 commits into
mainfrom
fix/list-outdent-and-lint

Conversation

@harbournick
Copy link
Copy Markdown
Collaborator

  • Fixes issue with list outdent converting from bullet to numbered
  • lint fixes

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with list outdenting behavior that was incorrectly converting bullet lists to numbered lists and includes various lint fixes.

  • Fixed logic in decreaseListIndent.js to prevent list type conversion during outdent operations
  • Updated test cases to verify the fix and align with new behavior expectations
  • General code cleanup including removal of unused variables and comment fixes

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/super-editor/src/core/commands/toggleList.js Removed unused switchingToOrdered variable
packages/super-editor/src/core/commands/decreaseListIndent.test.js Updated tests to reflect new list outdent behavior and removed outdated comment
packages/super-editor/src/core/commands/decreaseListIndent.js Fixed core logic to adopt parent list IDs and prevent definition regeneration
packages/super-editor/src/core/commands/backspaceNextToList.js Removed unused listDepth variable
packages/ooxml-inspector/src/children/cli.js Fixed template literal syntax in error message

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread packages/ooxml-inspector/src/children/cli.js
@harbournick harbournick merged commit 858cf04 into main Sep 2, 2025
6 checks passed
@harbournick harbournick deleted the fix/list-outdent-and-lint branch September 2, 2025 21:33
@harbournick
Copy link
Copy Markdown
Collaborator Author

🎉 This PR is included in version 0.16.0-next.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants