fix(config): tighten --config path handling#4465
Open
niki4smirn wants to merge 2 commits intosuperfly:masterfrom
Open
fix(config): tighten --config path handling#4465niki4smirn wants to merge 2 commits intosuperfly:masterfrom
niki4smirn wants to merge 2 commits intosuperfly:masterfrom
Conversation
Return error if config path doesn't exist
Author
|
Quick check-in: is there a preferred reviewer for changes under |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why:
The --config flag must now point to an existing file. Tests have been created to reflect this change.
Fixes #4382 and #4378.
Additionally, I noticed an inconsistency in how directory path passed to --config is handled. It seems that
appConfigFilePathsattempts to process directory parameter. However, in such case, the switch statement would return an error. Since the --config flag is described as "Path to application configuration file," I don't believe directory support is necessary.Documentation