Skip to content

Commit d76d25e

Browse files
fix
1 parent a73814b commit d76d25e

File tree

6 files changed

+16
-14
lines changed

6 files changed

+16
-14
lines changed

packages/openai-sdk-python/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ class SupermemoryOpenAIOptions:
347347
api_key: Optional[str] = None # Supermemory API key (or use env var)
348348
verbose: bool = False # Enable detailed logging
349349
mode: Literal["profile", "query", "full"] = "profile" # Memory injection mode
350-
add_memory: Literal["always", "never"] = "never" # Auto-save behavior
350+
add_memory: Literal["always", "never"] = "always" # Auto-save behavior
351351
```
352352

353353
### SupermemoryTools

packages/openai-sdk-python/src/supermemory_openai/middleware.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ class SupermemoryOpenAIOptions:
5050
mode: Literal["profile", "query", "full"] = "profile"
5151
"""Memory retrieval mode: 'profile', 'query', or 'full'."""
5252

53-
add_memory: Literal["always", "never"] = "never"
54-
"""Memory persistence mode: 'always' or 'never' (default)."""
53+
add_memory: Literal["always", "never"] = "always"
54+
"""Memory persistence mode: 'always' (default) or 'never'."""
5555

5656

5757
class SupermemoryProfileSearch:

packages/openai-sdk-python/uv.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/tools/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@ interface SupermemoryOpenAIOptions {
298298
apiKey?: string // Supermemory API key (or use SUPERMEMORY_API_KEY env var)
299299
baseUrl?: string // Custom API endpoint
300300
mode?: "profile" | "query" | "full" // Memory search mode (default: "profile")
301-
addMemory?: "always" | "never" // Auto-save conversations (default: "never")
301+
addMemory?: "always" | "never" // Auto-save conversations (default: "always")
302302
verbose?: boolean // Enable debug logging (default: false)
303303
}
304304
```
@@ -591,7 +591,7 @@ interface SupermemoryMastraOptions {
591591
apiKey?: string // Supermemory API key (or use SUPERMEMORY_API_KEY env var)
592592
baseUrl?: string // Custom API endpoint
593593
mode?: "profile" | "query" | "full" // Memory search mode (default: "profile")
594-
addMemory?: "always" | "never" // Auto-save conversations (default: "never")
594+
addMemory?: "always" | "never" // Auto-save conversations (default: "always")
595595
threadId?: string // Conversation ID for grouping messages
596596
verbose?: boolean // Enable debug logging (default: false)
597597
promptTemplate?: (data: MemoryPromptData) => string // Custom memory formatting
@@ -665,7 +665,7 @@ interface WithSupermemoryOptions {
665665
- **conversationId**: Optional conversation ID to group messages into a single document for contextual memory generation
666666
- **verbose**: Enable detailed logging of memory search and injection process (default: false)
667667
- **mode**: Memory search mode - "profile" (default), "query", or "full"
668-
- **addMemory**: Automatic memory storage mode - "always" or "never" (default: "never")
668+
- **addMemory**: Automatic memory storage mode - "always" (default) or "never"
669669

670670
## Available Tools
671671

packages/tools/src/openai/middleware.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ export interface SupermemoryOpenAIOptions {
3434
mode?: "profile" | "query" | "full"
3535
/**
3636
* Memory persistence mode:
37-
* - "always": Automatically save conversations as memories
38-
* - "never": Only retrieve memories, don't store new ones (default)
37+
* - "always": Automatically save conversations as memories (default)
38+
* - "never": Only retrieve memories, don't store new ones
3939
*/
4040
addMemory?: "always" | "never"
4141
}
@@ -445,7 +445,7 @@ export function createOpenAIMiddleware(
445445
baseUrl,
446446
verbose = false,
447447
mode = "profile",
448-
addMemory = "never",
448+
addMemory = "always",
449449
} = options
450450

451451
const logger = createLogger(verbose)

packages/tools/test/openai/unit.test.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,7 @@ describe("Unit: OpenAI withSupermemory", () => {
243243
containerTag: "user-123",
244244
customId: "conv-456",
245245
mode: "query",
246+
addMemory: "never",
246247
})
247248

248249
await wrapped.chat.completions.create({
@@ -435,6 +436,7 @@ describe("Unit: OpenAI withSupermemory", () => {
435436
const wrapped = withSupermemory(mockClient, {
436437
containerTag: "user-123",
437438
customId: "conv-456",
439+
addMemory: "never",
438440
})
439441

440442
await wrapped.chat.completions.create({
@@ -448,7 +450,7 @@ describe("Unit: OpenAI withSupermemory", () => {
448450
expect(fetchBody.containerTag).toBe("user-123")
449451
})
450452

451-
it("should default to never for addMemory", async () => {
453+
it("should default to always for addMemory", async () => {
452454
fetchMock.mockResolvedValue({
453455
ok: true,
454456
json: () => Promise.resolve(createMockProfileResponse()),
@@ -465,8 +467,8 @@ describe("Unit: OpenAI withSupermemory", () => {
465467
messages: [{ role: "user", content: "Hello" }],
466468
})
467469

468-
// Only 1 fetch (profile search), no memory add (default is "never")
469-
expect(fetchMock).toHaveBeenCalledTimes(1)
470+
// 2 fetches: profile search + memory add (default is "always")
471+
expect(fetchMock).toHaveBeenCalledTimes(2)
470472
})
471473
})
472474
})

0 commit comments

Comments
 (0)