fix: use component-defined color for GraphQL mapper#4754
Open
Lucky-Rathore wants to merge 1 commit into
Open
Conversation
The GraphQL component mapper was hardcoded to use black color instead of using the component's defined violet color. This made it appear darker than other core components. Fixes superplanehq#4483 Signed-off-by: Lucky Rathore <luckyrathore03@gmail.com>
|
👋 Commands for maintainers:
|
superplane-policy-bot
Bot
requested review from
forestileao,
lucaspin and
shiroyasha
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Changed the GraphQL mapper to use the component's defined color instead of hardcoded black.
Why
The GraphQL component was appearing darker than other core components because the mapper was using
getColorClass("black")instead of using the component's defined color (violet).How
Updated
web_src/src/pages/workflowv2/mappers/graphql.tsto usegetColorClass(context.componentDefinition.color)which matches the pattern used by other integration components.Closes #4483