feat: Add Env Vars to Runners#4789
Merged
Merged
Conversation
|
👋 Commands for maintainers:
|
shiroyasha
reviewed
May 14, 2026
Comment on lines
+101
to
+109
| value, err := secrets.GetKey(variable.Secret.Secret, variable.Secret.Key) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to resolve environment variable %s secret %s/%s: %w", name, variable.Secret.Secret, variable.Secret.Key, err) | ||
| } | ||
|
|
||
| resolved = append(resolved, BrokerEnvironmentVariable{ | ||
| Name: name, | ||
| Value: string(value), | ||
| }) |
Collaborator
There was a problem hiding this comment.
This is ok a temporary solution, but we will need to figure out a way to make this encrypted e2e down to the runner.
Lets create an issue for this to track progress.
Signed-off-by: André Calil <andre@calil.com.br>
andrecalil
force-pushed
the
feat/add-env-vars-to-runners
branch
from
343a74f to
47561d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP