Skip to content

fix: stabilize org settings layout when toggling change management#4790

Merged
shiroyasha merged 1 commit into
superplanehq:mainfrom
Vukotije:fix/org-settings-change-management-toggle-jitter
May 18, 2026
Merged

fix: stabilize org settings layout when toggling change management#4790
shiroyasha merged 1 commit into
superplanehq:mainfrom
Vukotije:fix/org-settings-change-management-toggle-jitter

Conversation

@Vukotije
Copy link
Copy Markdown
Collaborator

@Vukotije Vukotije commented May 14, 2026

Summary

Closes #4766
Fixing a few small UX issues on Organization → Settings → General when interacting with the Change Management switch:

  • Save Changes button no longer flashes "Saving..." on toggle. The Organization Name "Save Changes" button and the Change Management toggle were sharing the same useUpdateOrganization mutation instance, so flipping the switch flipped the unrelated button's isPending. The toggle now uses its own updateChangeManagementMutation instance.
  • No more horizontal jitter of the centered column on toggle. Showing/hiding the confirmation message (and other small height changes) crossed the scroll-overflow threshold and made the vertical scrollbar appear/disappear, which shifted the centered max-w-3xl content. Added [scrollbar-gutter:stable] to the org settings scroll container so the gutter is always reserved.
  • Confirmation toast only on enable. Previously turning the switch off briefly hid then re-showed the green message before clearing it. We now only show the green "Change management enabled" message when enabling. Failure toasts still appear in both directions and the switch reverts on error.

Files touched:

  • web_src/src/pages/organization/settings/General.tsx
  • web_src/src/pages/organization/settings/index.tsx

Test plan

  • On /{org}/settings/general, toggle Change Management on and off several times; the top "Save Changes" button never enters "Saving..." mode.
  • The centered settings column does not shake left/right while toggling.
  • The green "Change management enabled" message appears only when enabling, and toggling off does not show any confirmation message.
  • Force a failure (eg. block the network) and confirm the red "Failed to update change management" message still appears and the switch reverts to its previous state.
  • make format.js, make check.build.ui, and npm run lint:budget are all clean.

@superplanehq-integration
Copy link
Copy Markdown

👋 Commands for maintainers:

  • /sp start - Start an ephemeral machine (takes ~30s)
  • /sp stop - Stop a running machine (auto-executed on pr close)

Signed-off-by: Vukotije <vukanradojevicc@gmail.com>
@Vukotije Vukotije force-pushed the fix/org-settings-change-management-toggle-jitter branch from 80c535d to 8bd02c6 Compare May 16, 2026 13:14
@shiroyasha shiroyasha merged commit 9aab1c3 into superplanehq:main May 18, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stabilize jittery settings page

2 participants