fix: stabilize org settings layout when toggling change management#4790
Merged
shiroyasha merged 1 commit intoMay 18, 2026
Conversation
|
👋 Commands for maintainers:
|
Signed-off-by: Vukotije <vukanradojevicc@gmail.com>
80c535d to
8bd02c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4766
Fixing a few small UX issues on Organization → Settings → General when interacting with the Change Management switch:
useUpdateOrganizationmutation instance, so flipping the switch flipped the unrelated button'sisPending. The toggle now uses its ownupdateChangeManagementMutationinstance.max-w-3xlcontent. Added[scrollbar-gutter:stable]to the org settings scroll container so the gutter is always reserved.Files touched:
web_src/src/pages/organization/settings/General.tsxweb_src/src/pages/organization/settings/index.tsxTest plan
/{org}/settings/general, toggle Change Management on and off several times; the top "Save Changes" button never enters "Saving..." mode.make format.js,make check.build.ui, andnpm run lint:budgetare all clean.