fix(network): wake publisher after draining host channel#930
Open
chiehwangs wants to merge 3 commits into
Open
fix(network): wake publisher after draining host channel#930chiehwangs wants to merge 3 commits into
chiehwangs wants to merge 3 commits into
Conversation
## Description Published-port responses can stall behind a slow host-side client because the inbound relay only wakes the poll loop after the host socket write completes. ## Root Cause Receiving from `to_host_rx` frees capacity for more smoltcp-to-host data, but the wake happened after `write_all().await`. When that write blocks, the poll loop is not notified that it can refill the channel. ## Fix Wake the poll loop immediately after draining `to_host_rx`, before awaiting the host socket write, and add a regression test that covers the blocked-write timing.
Create a no-op commit to request a fresh GitHub Actions run after the previous self-hosted runner failure.
Create another no-op commit to request a fresh GitHub Actions run without changing code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Published-port responses can stall behind a slow host-side client because the inbound relay only wakes the poll loop after the host socket write completes.
Root Cause
Receiving from
to_host_rxfrees capacity for more smoltcp-to-host data, but the wake happened afterwrite_all().await. When that write blocks, the poll loop is not notified that it can refill the channel.Fix
Wake the poll loop immediately after draining
to_host_rx, before awaiting the host socket write, and add a regression test that covers the blocked-write timing.