Skip to content

Commit fa26c9b

Browse files
authored
chore: rename kmeans_dimension_reduction to kmeans_dimension (#376)
Signed-off-by: usamoi <usamoi@outlook.com>
1 parent 7a30c48 commit fa26c9b

3 files changed

Lines changed: 7 additions & 7 deletions

File tree

src/index/vchordrq/am/am_build.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1275,12 +1275,12 @@ fn make_internal_build(
12751275
) -> Vec<Structure<Normalized>> {
12761276
use humansize::{BINARY, format_size};
12771277
use std::iter::once;
1278-
let (reduction, sample_dim) = match internal_build.kmeans_dimension_reduction {
1278+
let (reduction, sample_dim) = match internal_build.kmeans_dimension {
12791279
None => (None, vector_options.dims as usize),
12801280
Some(d) if d < vector_options.dims => (Some(d as usize), d as usize),
12811281
Some(d) => {
12821282
pgrx::warning!(
1283-
"ignoring `kmeans_dimension_reduction = {}` because it is less than the vector dimension {}",
1283+
"ignoring `kmeans_dimension = {}` because it is less than the vector dimension {}",
12841284
d,
12851285
vector_options.dims
12861286
);

src/index/vchordrq/types.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,9 @@ pub struct VchordrqInternalBuildOptions {
5454
pub build_threads: u16,
5555
#[serde(default = "VchordrqInternalBuildOptions::default_kmeans_algorithm")]
5656
pub kmeans_algorithm: KMeansAlgorithm,
57-
#[serde(default = "VchordrqInternalBuildOptions::default_kmeans_dimension_reduction")]
57+
#[serde(default = "VchordrqInternalBuildOptions::default_kmeans_dimension")]
5858
#[validate(range(min = 1, max = 16000))]
59-
pub kmeans_dimension_reduction: Option<u32>,
59+
pub kmeans_dimension: Option<u32>,
6060
}
6161

6262
impl VchordrqInternalBuildOptions {
@@ -87,7 +87,7 @@ impl VchordrqInternalBuildOptions {
8787
fn default_kmeans_algorithm() -> KMeansAlgorithm {
8888
KMeansAlgorithm::Lloyd {}
8989
}
90-
fn default_kmeans_dimension_reduction() -> Option<u32> {
90+
fn default_kmeans_dimension() -> Option<u32> {
9191
None
9292
}
9393
}
@@ -101,7 +101,7 @@ impl Default for VchordrqInternalBuildOptions {
101101
kmeans_iterations: Self::default_kmeans_iterations(),
102102
build_threads: Self::default_build_threads(),
103103
kmeans_algorithm: Self::default_kmeans_algorithm(),
104-
kmeans_dimension_reduction: Self::default_kmeans_dimension_reduction(),
104+
kmeans_dimension: Self::default_kmeans_dimension(),
105105
}
106106
}
107107
}

tests/vchordrq/approximate.slt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ residual_quantization = true
1111
[build.internal]
1212
lists = [33]
1313
spherical_centroids = false
14-
kmeans_dimension_reduction = 2
14+
kmeans_dimension = 2
1515
kmeans_algorithm.hierarchical = {}
1616
$$);
1717

0 commit comments

Comments
 (0)