⚡ Bolt: OOM protection for L1 cache & fetchOptions allocation optimization#19
⚡ Bolt: OOM protection for L1 cache & fetchOptions allocation optimization#19
Conversation
Co-authored-by: suranig <24814104+suranig@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
💡 What: Introduced a maximum capacity (
MAX_L1_CACHE_SIZE= 1000) for the L1 in-memory cache with a FIFO eviction strategy. Also optimized the object allocation offetchOptionsto avoid unnecessary object spread operations on cache fetches.🎯 Why: The L1
Mapcache lacked any bounds limit, allowing it to potentially grow unbounded over time and lead to memory exhaustion (OOM), which poses a DoS risk in long-running processes or on highly dynamic routes with high cache miss variance. The object spread optimization reduces unnecessary garbage collection overhead on the very hotfetchpath.📊 Impact: Restricts memory footprint to a strict maximum limit, ensuring stability. CPU overhead is slightly reduced per cache
fetchcall when custom options are omitted.🔬 Measurement: Run the new L1 cache eviction tests using
npm run testand check that the tests verify the oldest entries are purged as expected. Memory footprint can be measured and will no longer grow beyond ~1000 concurrent L1 keys.PR created automatically by Jules for task 12425408148880868313 started by @suranig