fix: nable multiple navbars on a page#39
Open
SalahAdDin wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intro
Following this PR, we wanted to propose an alternative for it.
Description
Here is the breakdown of why Astronav.astro is structurally necessary:
1. The "Desktop Dropdown" Problem
The script currently handles Dropdown toggles as well as the mobile menu.
{isMobile && <MenuIcon />}), your Dropdowns will stop working on desktop because the script won't be present.2. Scoping & "Islands" (The Fix We Just Made)
We just established that we need a "root" element to isolate multiple navbars on the same page.
Astronav.astroprovides this boundary automatically via the<nav class="astronav-toggle-root">wrapper.Astronav.astro, the user would have to manually add a wrapper div with a specific class to every navbar for the code to work. This degrades the Developer Experience (DX) and makes the library more error-prone to use.3. Separation of Concerns
It is cleaner to have a dedicated controller component orchestrate the behavior of the children (Menu, Dropdowns, Sticky behaviors) rather than stuffing global navigation logic into a tiny icon component.
Correction on
closeOnClickYou are absolutely right that
closeOnClickbelongs on the button. In fact, it is already implemented that way!Astronav.astrodoes not accept acloseOnClickprop.MenuIcon.astrodoes accept it and renders it as a data attribute (data-closeOnClick).