docs(proposal): convert vm cpu model proposal to explore improvements#2464
Merged
nikimanoledaki merged 1 commit intoApr 20, 2026
Merged
Conversation
laurall974
force-pushed
the
pr-2291-reboot
branch
from
4041e22 to
8493261
Compare
nikimanoledaki
previously approved these changes
Apr 17, 2026
Collaborator
nikimanoledaki
left a comment
nikimanoledaki
left a comment
There was a problem hiding this comment.
Thank you @laurall974, LGTM. To keep things moving, I propose that we check this draft in git first. Then, we can create follow-up PRs to address the review comments in the original PR. Lastly, we'll apply our changes, which is to create Proposal 1 with Kaiyi's proposal and Proposal 2 with Vasilis' proposal (SPEC power).
Collaborator
|
will we choose between proposals 1 and 2 ? |
Collaborator
yes, exactly we'll evaluate the pros and cons of each one, each person will share their feedback, and then we'll reach consensus |
sunya-ch
previously approved these changes
Apr 19, 2026
Collaborator
sunya-ch
left a comment
sunya-ch
left a comment
There was a problem hiding this comment.
Leave some comments but I think it is good to merge and move on
laurall974
dismissed stale reviews from sunya-ch and nikimanoledaki
via
18827e7
laurall974
force-pushed
the
pr-2291-reboot
branch
3 times, most recently
from
4f8042b to
db8ac56
Compare
laurall974
force-pushed
the
pr-2291-reboot
branch
from
db8ac56 to
b71e87f
Compare
nikimanoledaki
approved these changes
Apr 20, 2026
…e improvements Signed-off-by: Laura Llinares <llinares.laura@cern.ch>
nikimanoledaki
force-pushed
the
pr-2291-reboot
branch
from
b71e87f to
bc7165c
Compare
nikimanoledaki
merged commit bab38cb
into
sustainable-computing-io:main
25 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the same changes as #2291. I opened this as a replacement.
Please review this PR instead; #2291 can be closed once this is merged.
We are reactivating and evolving this proposal as part of an ongoing effort to consolidate work testing different approaches. This allows us to have more freedom regarding the future architecture and modeling of the final proposal.