Skip to content

feat: implement steward-ward pattern for schedule and dispatch goroutines#13

Open
svaloumas wants to merge 1 commit into
mainfrom
feat/restart-unhealthy-scheduler-and-dispatcher
Open

feat: implement steward-ward pattern for schedule and dispatch goroutines#13
svaloumas wants to merge 1 commit into
mainfrom
feat/restart-unhealthy-scheduler-and-dispatcher

Conversation

@svaloumas
Copy link
Copy Markdown
Owner

  • Adds Scheduler.NewSteward method
  • Turns Scheduler.Dispatch and Scheduler.Schedule methods to wards
  • Refactors WorkService.Dispatch method

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 25, 2022

Codecov Report

❌ Patch coverage is 59.77654% with 72 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.74%. Comparing base (732aec4) to head (9ed3ebc).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/core/service/schedulersrv/service.go 65.67% 45 Missing and 1 partial ⚠️
internal/core/service/worksrv/service.go 29.72% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   76.73%   75.74%   -1.00%     
==========================================
  Files          32       32              
  Lines        3271     3360      +89     
==========================================
+ Hits         2510     2545      +35     
- Misses        538      593      +55     
+ Partials      223      222       -1     
Flag Coverage Δ
unittests 75.74% <59.77%> (-1.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svaloumas svaloumas force-pushed the feat/restart-unhealthy-scheduler-and-dispatcher branch from 9a53a2b to 049a13d Compare November 25, 2022 16:51
@svaloumas svaloumas force-pushed the feat/restart-unhealthy-scheduler-and-dispatcher branch from 049a13d to 9ed3ebc Compare November 25, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant