This repository was archived by the owner on Nov 11, 2023. It is now read-only.
Support mps cpu#249
Open
Tps-F wants to merge 5 commits into
Open
Conversation
magic-akari
reviewed
Jun 22, 2023
Contributor
|
I still cannot run Are there any other issues that need to be resolved? |
Contributor
Author
|
I did not get that error in my environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
I made it compatible with cpu and mps since training only seems to work with cuda devices.
About the change
DistributedDataParallel is not likely to work with CPU or mps, so I used DataParallel.
The reason I'm making the change to
dist.init_process_groupis that mps may be supported in DDP in the future.The rest was simply replacing
.cuda()with.to()My English is poor, so if you have any questions, please feel free to ask!