perf: use sets internally for PressedKeys#419
Open
WarningImHack3r wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 7550768 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WarningImHack3r
commented
May 4, 2026
| // but keep other modifier keys that might still be pressed | ||
| // This prevents keys from getting "stuck" in the pressed state | ||
| this.#pressedKeys = this.#pressedKeys.filter((k) => modifierKeys.includes(k)); | ||
| this.#pressedKeys = this.#pressedKeys.intersection(modifierKeys); |
Author
There was a problem hiding this comment.
Set.prototype.intersection is only baseline since 2024/06, tell me if you want me to add a fallback for that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just started using
PressedKeysin my project, and I looked at the code because I was curious how it workedAs it turns out, I spotted a few performance points that could be improved, so here we are
Basically, I:
Sets for O(1) deletions & lookups, as well as builtin uniquenesshasby lowercasing keys on-the-fly and leveragingSetmethodsAll tests pass, so I assume there is no regression and it's safe to merge (maybe?)
I'm not sure how we could measure the improvements, but it's fair to say this is faster than arrays
On another note, pnpm suggested adding missing packages to the workspace, so I thought why not pushing that too as we're here
Tell me what you think!