Identity de-dupe with replacers in uneval#159
Open
lucacasonato wants to merge 2 commits into
Open
Conversation
This commit implements a mechanism to enable reducers in `uneval` to not duplicate values that are referenced multiple times. This fix involves sometimes calling `replacer` twice for the same value. Right now it also calls replacer twice for the same value when we can know to avoid it, but the bookkeeping required to avoid it likely not worth the memory complexity it adds.
🦋 Changeset detectedLatest commit: 1702212 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements a mechanism to enable
reducers in
unevalto not duplicate values thatare referenced multiple times.
This fix involves sometimes calling
replacertwice for the same value. Right now it also calls
replacer twice for the same value when we can know
to avoid it, but the bookkeeping required to avoid
it likely not worth the memory complexity it adds.
Fixes #158