fix: improve tutorial dark mode contrast#1978
Open
Sean-Kenneth-Doherty wants to merge 1 commit into
Open
Conversation
|
@Sean-Kenneth-Doherty is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Local validation for
Browser smoke: I started the local dev server, set
The Vercel status remains blocked on team authorization, so this is local validation only. The checkout is clean after validation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partially addresses #627 by cleaning up two dark-mode contrast issues in tutorial examples.
$env/static/publicpreview use the tutorial foreground/background CSS variables instead of hard-coded white/blackI left the kitten image/background item out of this PR because that needs asset/background cleanup rather than a simple contrast fix.
Validation
SHARP_IGNORE_GLOBAL_LIBVIPS=1 mise exec node@24.15.0 -- pnpm install --frozen-lockfilemise exec node@24.15.0 -- pnpm prettier --write <changed files>mise exec node@24.15.0 -- pnpm --filter svelte.dev exec node --input-type=module -e "compile changed Svelte files"git diff --checkmise exec node@24.15.0 -- pnpm --filter svelte.dev lintmise exec node@24.15.0 -- pnpm --filter svelte.dev checkrgb(230, 230, 230)and dark env-static-public main colors resolved torgb(46, 46, 46)/rgb(230, 230, 230)