fix: create offscreen effects with correct anchor#18086
Draft
Rich-Harris wants to merge 10 commits into
Draft
Conversation
🦋 Changeset detectedLatest commit: 1d93465 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Member
|
Interesting approach! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another take on #18079. The symbol thing felt like a bit of a kludge, so I started poking about at possible alternatives and this is where I landed.
Having done so I think maybe @dummdidumm was right the first time (many such cases) — without the symbol, the only way to get the HMR wrapper to send the right anchor to its component is to create the effect onscreen and then remove it if we want to defer it, which is extra work. Still, there might be some merit in only storing the offscreen effects rather than fragments — not sure — so I figured I'd create a PR for posterity.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint