fix: preserve bind:this values in effect teardown#18159
Open
RazinShafayet2007 wants to merge 9 commits into
Open
fix: preserve bind:this values in effect teardown#18159RazinShafayet2007 wants to merge 9 commits into
bind:this values in effect teardown#18159RazinShafayet2007 wants to merge 9 commits into
Conversation
🦋 Changeset detectedLatest commit: 4d1ce5a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18150
bind:thiswas clearing its bound state during destroy-time teardown, and that internalupdate(null, ...parts)write was overwriting the old-value snapshot that$effectcleanup reads rely on. As a result, cleanup code reading abind:thisstate directly could seenullinstead of the last bound element or component. This fixes that by preserving thepre-nullteardown values for the signals used by the binding expression before clearing the binding, so effect teardowns continue to see the expected last value while keeping the existingbind:thiscleanup behavior intact.Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint