Skip to content

Commit 582cb3b

Browse files
committed
refs #4850 - fix extension 'x-' prefix decoration
1 parent eb1dc70 commit 582cb3b

4 files changed

Lines changed: 7 additions & 10 deletions

File tree

modules/swagger-core/src/main/java/io/swagger/v3/core/jackson/ModelResolver.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@
5353
import io.swagger.v3.oas.annotations.media.SchemaProperty;
5454
import io.swagger.v3.oas.models.Components;
5555
import io.swagger.v3.oas.models.ExternalDocumentation;
56-
import io.swagger.v3.oas.models.SpecVersion;
5756
import io.swagger.v3.oas.models.media.ArraySchema;
5857
import io.swagger.v3.oas.models.media.ComposedSchema;
5958
import io.swagger.v3.oas.models.media.Discriminator;
@@ -227,7 +226,7 @@ public Schema resolve(AnnotatedType annotatedType, ModelConverterContext context
227226
if (resolvedArrayAnnotation == null) {
228227
schemaRefFromAnnotation = resolvedSchemaAnnotation.ref();
229228
if (!openapi31) {
230-
return new JsonSchema().$ref(resolvedSchemaAnnotation.ref()).name(name);
229+
return new Schema().$ref(resolvedSchemaAnnotation.ref()).name(name);
231230
}
232231
} else {
233232
ArraySchema schema = new ArraySchema();
@@ -2799,7 +2798,8 @@ protected Map<String, Object> resolveExtensions(AnnotatedType a, io.swagger.v3.o
27992798
if (arraySchema != null &&
28002799
arraySchema.extensions() != null &&
28012800
arraySchema.extensions().length > 0) {
2802-
return AnnotationsUtils.getExtensions(openapi31, false, arraySchema.extensions());
2801+
boolean usePrefix = !openapi31;
2802+
return AnnotationsUtils.getExtensions(openapi31, usePrefix, arraySchema.extensions());
28032803
}
28042804
return null;
28052805
}

modules/swagger-core/src/main/java/io/swagger/v3/core/util/AnnotationsUtils.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -539,7 +539,8 @@ public static Optional<Schema> getArraySchema(io.swagger.v3.oas.annotations.medi
539539
}
540540

541541
if (arraySchema.extensions().length > 0) {
542-
Map<String, Object> extensions = AnnotationsUtils.getExtensions(openapi31, false, arraySchema.extensions());
542+
boolean usePrefix = !openapi31;
543+
Map<String, Object> extensions = AnnotationsUtils.getExtensions(openapi31, usePrefix, arraySchema.extensions());
543544
if (extensions != null) {
544545
extensions.forEach(arraySchemaObject::addExtension);
545546
}

modules/swagger-jaxrs2/src/test/java/io/swagger/v3/jaxrs2/ReaderTest.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -150,15 +150,13 @@
150150
import java.util.Arrays;
151151
import java.util.HashMap;
152152
import java.util.HashSet;
153-
import java.util.LinkedHashSet;
154153
import java.util.List;
155154
import java.util.Map;
156155
import java.util.Optional;
157156
import java.util.Set;
158157
import java.util.concurrent.CompletableFuture;
159158
import java.util.concurrent.CopyOnWriteArrayList;
160159

161-
import static io.swagger.v3.oas.models.SpecVersion.V31;
162160
import static org.testng.Assert.assertEquals;
163161
import static org.testng.Assert.assertFalse;
164162
import static org.testng.Assert.assertNotEquals;
@@ -5348,9 +5346,8 @@ public void testTicket4065() {
53485346

53495347
@Test(description = "Extensions Tests OAS 3.1")
53505348
public void testExtensionsOAS31() {
5351-
OpenAPI o = new OpenAPI(V31);
5352-
SwaggerConfiguration config = new SwaggerConfiguration().openAPI(o).openAPI31(true);
5353-
Reader reader = new Reader(o, new Paths(), new LinkedHashSet<>(), new Components(), config);
5349+
SwaggerConfiguration config = new SwaggerConfiguration().openAPI31(true);
5350+
Reader reader = new Reader(config);
53545351

53555352
OpenAPI openAPI = reader.read(Ticket4850Resource.class);
53565353
assertNotNull(openAPI);

modules/swagger-jaxrs2/src/test/java/io/swagger/v3/jaxrs2/resources/Ticket4850Resource.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
import javax.ws.rs.GET;
88
import javax.ws.rs.Path;
9-
import javax.ws.rs.Produces;
109

1110
@Path("/bar")
1211
public class Ticket4850Resource {

0 commit comments

Comments
 (0)