Skip to content

Consistent usage of TestNG#4879

Closed
strangelookingnerd wants to merge 2 commits intoswagger-api:masterfrom
strangelookingnerd:use_testng
Closed

Consistent usage of TestNG#4879
strangelookingnerd wants to merge 2 commits intoswagger-api:masterfrom
strangelookingnerd:use_testng

Conversation

@strangelookingnerd
Copy link
Copy Markdown
Contributor

@strangelookingnerd strangelookingnerd commented Apr 25, 2025

This PR aims to remove usage of JUnit and consistently use TestNG across the modules instead.

Changes include:

  • Use TestNG annotations over JUnit counterparts
  • Use TestNG assertions over JUnit counterparts (also simplify some assertions in the process)
  • Consistently use static imports for TestNG assertions
  • Remove JUnit depencency if not required
  • Add TestNG dependency if required

There is one exception in swagger-maven-plugin where JUnit is still required by the underlying maven test suite and thus tests can not be migrated.

@strangelookingnerd
Copy link
Copy Markdown
Contributor Author

I can not reproduce the build / test failures using JDK 11 or 17 reported by the actions using:

./mvnw --no-transfer-progress -B install --file pom.xml
cd ./modules/swagger-gradle-plugin
./gradlew build --info

Am I missing something here?

@frantuma
Copy link
Copy Markdown
Contributor

frantuma commented May 7, 2025

Thanks! Included and replaced by #4885

@frantuma frantuma closed this May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants