Consistent usage of TestNG#4879
Closed
strangelookingnerd wants to merge 2 commits intoswagger-api:masterfrom
strangelookingnerd:use_testng
Closed
Consistent usage of TestNG#4879strangelookingnerd wants to merge 2 commits intoswagger-api:masterfrom strangelookingnerd:use_testng
strangelookingnerd wants to merge 2 commits intoswagger-api:masterfrom
strangelookingnerd:use_testng
Conversation
Contributor
Author
|
I can not reproduce the build / test failures using JDK 11 or 17 reported by the actions using: ./mvnw --no-transfer-progress -B install --file pom.xml
cd ./modules/swagger-gradle-plugin
./gradlew build --infoAm I missing something here? |
Contributor
|
Thanks! Included and replaced by #4885 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to remove usage of JUnit and consistently use TestNG across the modules instead.
Changes include:
There is one exception in
swagger-maven-pluginwhere JUnit is still required by the underlying maven test suite and thus tests can not be migrated.