refactor: streamline tag filtering logic in SpecFilter - #5256
Open
Mattias-Sehlstedt wants to merge 2 commits into
Open
refactor: streamline tag filtering logic in SpecFilter#5256Mattias-Sehlstedt wants to merge 2 commits into
Mattias-Sehlstedt wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thank you for contributing to swagger-core!
Please fill out the following information to help us review your PR efficiently.
Description
Introduced an object (
TagFilter) to couple theTagfiltering fields to each other. it also breaks out the filtering logic into a private support method. This is part of making the behavior more understandable with the intent of making the necessary changes needed for the OAS 3.2Tagfunctionality easier to integrate. Mainly the pruning of filteredTagsthat are involved with the newparentfield (i.e., if the parent is removed as part of the regular filtering, then the children should no longer refer to it).This change is extracted from the Tag implementation present on branch.
Type of Change
Checklist
Screenshots / Additional Context