Skip to content

refactor: streamline tag filtering logic in SpecFilter - #5256

Open
Mattias-Sehlstedt wants to merge 2 commits into
swagger-api:masterfrom
Mattias-Sehlstedt:refactor-tag-filtering
Open

refactor: streamline tag filtering logic in SpecFilter#5256
Mattias-Sehlstedt wants to merge 2 commits into
swagger-api:masterfrom
Mattias-Sehlstedt:refactor-tag-filtering

Conversation

@Mattias-Sehlstedt

Copy link
Copy Markdown
Contributor

Pull Request

Thank you for contributing to swagger-core!

Please fill out the following information to help us review your PR efficiently.


Description

Introduced an object (TagFilter) to couple the Tag filtering fields to each other. it also breaks out the filtering logic into a private support method. This is part of making the behavior more understandable with the intent of making the necessary changes needed for the OAS 3.2 Tag functionality easier to integrate. Mainly the pruning of filtered Tags that are involved with the new parent field (i.e., if the parent is removed as part of the regular filtering, then the children should no longer refer to it).

This change is extracted from the Tag implementation present on branch.

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • ♻️ Refactor (non-breaking change)
  • 🧪 Tests
  • 📝 Documentation
  • 🧹 Chore (build or tooling)

Checklist

  • I have added/updated tests as needed
  • I have added/updated documentation where applicable
  • The PR title is descriptive
  • The code builds and passes tests locally
  • I have linked related issues (if any)

Screenshots / Additional Context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant