Skip to content

feat(splash-screen): allow to pass arbitrary version to splash screen #5473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
char0n merged 2 commits into from
May 11, 2025
Merged

feat(splash-screen): allow to pass arbitrary version to splash screen #5473

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4a8aae
feat(splash-screen): allow to pass arbitrary version to splash screen
char0n May 11, 2025
684acda
refactor: simplify
char0n May 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/plugins/splash-screen/components/SplashScreen/SplashScreen.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import classNames from 'classnames';
// eslint-disable-next-line import/no-unresolved
import logo from '../../assets/logo.svg?raw';

Comment thread
char0n marked this conversation as resolved.
const SplashScreen = ({ isOpen = true, getComponent }) => {
const SplashScreen = ({ isOpen = true, version, getComponent }) => {
const { PACKAGE_VERSION } = buildInfo; // eslint-disable-line no-undef
const SplashScreenSpinner = getComponent('SplashScreenSpinner');
const [isHidden, setHidden] = useState(!isOpen);
Expand All @@ -24,7 +24,7 @@ const SplashScreen = ({ isOpen = true, getComponent }) => {
>
<figure className="swagger-editor__splash-screen-figure">
<img width="100%" src={logo} alt="Swagger Editor" />
<figcaption>{PACKAGE_VERSION}</figcaption>
<figcaption>{version ?? PACKAGE_VERSION}</figcaption>
<SplashScreenSpinner />
</figure>
</div>
Expand All @@ -33,6 +33,7 @@ const SplashScreen = ({ isOpen = true, getComponent }) => {

SplashScreen.propTypes = {
isOpen: PropTypes.bool,
version: PropTypes.string,
getComponent: PropTypes.func.isRequired,
};

Expand Down