Skip to content

chore(editor-monaco): expose Monaco themes through the plugin system#5511

Merged
glowcloud merged 2 commits into
nextfrom
expose-monaco-themes
May 28, 2025
Merged

chore(editor-monaco): expose Monaco themes through the plugin system#5511
glowcloud merged 2 commits into
nextfrom
expose-monaco-themes

Conversation

@glowcloud

Copy link
Copy Markdown
Contributor

No description provided.

@glowcloud glowcloud requested a review from char0n May 28, 2025 12:41
@glowcloud glowcloud self-assigned this May 28, 2025
Comment thread src/plugins/editor-monaco/index.js Outdated
monaco,
monacoInitializationDeferred: () => monacoInitializationDeferred,
monacoThemes: {
seVsDarkTheme,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
seVsDarkTheme,
'se-vs-dark': seVsDarkTheme,
'se-vs-light': seVsLightTheme,

@char0n char0n left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one suggestion

@glowcloud glowcloud merged commit aee9dd6 into next May 28, 2025
4 checks passed
@glowcloud glowcloud deleted the expose-monaco-themes branch May 28, 2025 13:03
@swagger-bot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 5.0.0-alpha.109 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants