Skip to content

feat: expose type definitions for swagger-editor and props-change-watcher plugin#5521

Merged
robert-hebel-sb merged 4 commits into
nextfrom
feat/poc-swagger-editor-ts-plugin
Jun 24, 2025
Merged

feat: expose type definitions for swagger-editor and props-change-watcher plugin#5521
robert-hebel-sb merged 4 commits into
nextfrom
feat/poc-swagger-editor-ts-plugin

Conversation

@robert-hebel-sb

@robert-hebel-sb robert-hebel-sb commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@robert-hebel-sb robert-hebel-sb requested a review from char0n June 9, 2025 22:32
@robert-hebel-sb robert-hebel-sb marked this pull request as draft June 9, 2025 22:32
@robert-hebel-sb robert-hebel-sb force-pushed the feat/poc-swagger-editor-ts-plugin branch from fd93a12 to ec10f8a Compare June 17, 2025 13:26
@robert-hebel-sb robert-hebel-sb changed the title feat: PoC basic type definitions for swagger editor feat: expose type definitions for swagger-editor and props-change-watcher plugin Jun 17, 2025
@robert-hebel-sb robert-hebel-sb marked this pull request as ready for review June 17, 2025 13:40

@glowcloud glowcloud left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how precise we want to be with the types for now, but leaving some comments for those that might be wrong.

Comment thread src/types/system.ts Outdated
Comment thread src/types/system.ts Outdated
Comment thread src/types/system.ts Outdated
Comment thread src/types/system.ts Outdated
Comment thread src/types/swagger-editor.ts Outdated
Comment thread src/plugins/props-change-watcher/hooks/use-prop-change.ts Outdated
Comment thread package.json Outdated

@glowcloud glowcloud left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just left comments for two possible changes.

Comment thread src/types/system.ts Outdated
Comment thread src/types/system.ts Outdated
@robert-hebel-sb robert-hebel-sb merged commit 66b36ad into next Jun 24, 2025
4 checks passed
@robert-hebel-sb robert-hebel-sb deleted the feat/poc-swagger-editor-ts-plugin branch June 24, 2025 08:21
@swagger-bot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 5.0.0-alpha.110 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants