Skip to content

fix: mitigate ReDoS when generating examples from pattern #10477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glowcloud merged 4 commits into from
Jun 3, 2025
+25 −3
Merged

fix: mitigate ReDoS when generating examples from pattern #10477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f77340
fix: mitigate ReDoS when generating examples from pattern
glowcloud Jun 2, 2025
7062410
fix: provide more restrictive regex
glowcloud Jun 3, 2025
e32c2e1
chore: update code comment
glowcloud Jun 3, 2025
30b09f7
fix: apply code review changes
glowcloud Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/core/plugins/json-schema-2020-12-samples/fn/core/random.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,18 @@ export const bytes = (length) => randomBytes(length)

Comment thread
glowcloud marked this conversation as resolved.
export const randexp = (pattern) => {
try {
const randexpInstance = new RandExp(pattern)
/**
* Applying maximum value (100) to numbers from regex patterns to avoid ReDoS:
* 1. {x}
* 2. {x,}
* 3. {,y}
* 4. {x,y}
*/
const patternSanitizer =
/(?<=(?<!\\)\{)(\d{3,})(?=\})|(?<=(?<!\\)\{\d*,)(\d{3,})(?=\})|(?<=(?<!\\)\{)(\d{3,})(?=,\d*\})/g
const safePattern = pattern.replace(patternSanitizer, "100")
const randexpInstance = new RandExp(safePattern)
randexpInstance.max = 100
return randexpInstance.gen()
} catch {
// invalid regex should not cause a crash (regex syntax varies across languages)
Expand Down
15 changes: 13 additions & 2 deletions src/core/plugins/json-schema-5-samples/fn/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,19 @@ import memoizeN from "core/utils/memoizeN"

const generateStringFromRegex = (pattern) => {
try {
const randexp = new RandExp(pattern)
return randexp.gen()
/**
* Applying maximum value (100) to numbers from regex patterns to avoid ReDoS:
* 1. {x}
* 2. {x,}
* 3. {,y}
* 4. {x,y}
*/
const patternSanitizer =
/(?<=(?<!\\)\{)(\d{3,})(?=\})|(?<=(?<!\\)\{\d*,)(\d{3,})(?=\})|(?<=(?<!\\)\{)(\d{3,})(?=,\d*\})/g
const safePattern = pattern.replace(patternSanitizer, "100")
const randexpInstance = new RandExp(safePattern)
randexpInstance.max = 100
return randexpInstance.gen()
} catch (e) {
// Invalid regex should not cause a crash (regex syntax varies across languages)
return "string"
Expand Down