Skip to content

Revert "fix(utils): disallow schema type array value string" #10710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukaszzazulak merged 1 commit into from
Feb 4, 2026
Merged

Revert "fix(utils): disallow schema type array value string" #10710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/core/utils/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,7 @@ function validateValueBySchema(value, schema, requiredByParam, bypassRequiredChe
let stringCheck = type === "string" && value
let arrayCheck = type === "array" && Array.isArray(value) && value.length
let arrayListCheck = type === "array" && Im.List.isList(value) && value.count()
let arrayStringCheck = type === "array" && typeof value === "string" && value
let fileCheck = type === "file" && value instanceof win.File
let booleanCheck = type === "boolean" && (value || value === false)
let numberCheck = type === "number" && (value || value === 0)
Expand All @@ -474,7 +475,7 @@ function validateValueBySchema(value, schema, requiredByParam, bypassRequiredChe
let objectStringCheck = type === "object" && typeof value === "string" && value

const allChecks = [
stringCheck, arrayCheck, arrayListCheck, fileCheck,
stringCheck, arrayCheck, arrayListCheck, arrayStringCheck, fileCheck,
booleanCheck, numberCheck, integerCheck, objectCheck, objectStringCheck,
]

Expand Down
12 changes: 0 additions & 12 deletions test/e2e-cypress/e2e/features/try-it-out-schema-type-array-example-type-string.cy.js
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions ...e-cypress/static/documents/features/try-it-out-schema-type-array-example-type-string.yaml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion test/unit/core/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,7 +749,7 @@ describe("utils", () => {
type: "array"
}
value = "[1]"
assertValidateParam(param, value, ["Required field is not provided"])
assertValidateParam(param, value, [])

// valid array, items match type
param = {
Expand Down