Skip to content

fix(config): fix parameterMacro typo in type-cast mappings#10841

Open
yogeshwaran-c wants to merge 1 commit intoswagger-api:masterfrom
yogeshwaran-c:fix/parameterMacro-typo-in-mappings
Open

fix(config): fix parameterMacro typo in type-cast mappings#10841
yogeshwaran-c wants to merge 1 commit intoswagger-api:masterfrom
yogeshwaran-c:fix/parameterMacro-typo-in-mappings

Conversation

@yogeshwaran-c
Copy link
Copy Markdown

Description

The type-cast mapping key for parameterMacro was misspelled as paramaterMacro (missing the 'e' in "parameter") in src/core/config/type-cast/mappings.js.

This typo meant that the parameterMacro configuration option was never matched by the type-casting system when provided via query string or other string-based configuration sources. The key in mappings.js did not match the key used everywhere else in the codebase (parameterMacro in defaults.js, spec/actions.js, swagger-client/index.js, etc.).

Motivation and Context

Found while reviewing the type-cast mappings for completeness. Every other reference in the codebase uses parameterMacro (with an 'e'), confirming this was an inadvertent typo.

How Has This Been Tested?

  • Searched the entire codebase for both paramaterMacro and parameterMacro
  • Only mappings.js used the misspelled version
  • All other references (defaults.js, spec/actions.js, swagger-client/index.js, parameter-row.jsx) consistently use parameterMacro

Screenshots (if appropriate):

N/A

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

The type-cast mapping key was misspelled as "paramaterMacro" instead
of "parameterMacro", which meant the parameterMacro configuration
option was never properly type-cast when provided via query string
or other string-based configuration sources.
@yogeshwaran-c yogeshwaran-c force-pushed the fix/parameterMacro-typo-in-mappings branch from 82f7825 to 5017c92 Compare April 20, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant