fix(grammar): fix secondary compoments grammar#91
Merged
Conversation
inputs field is not allowed.
There was a problem hiding this comment.
Pull request overview
This PR removes the "inputs" field from the ComponentsExpression grammar, as indicated by the description stating that the "inputs" field is not allowed. The change updates the type definitions, grammar files, documentation, and test fixtures to reflect that only "parameters", "successActions", and "failureActions" are valid fields for $components expressions.
Changes:
- Removed "inputs" from the ComponentsExpression field type definition
- Removed test fixture for
$components.inputs.username - Updated grammar opcodes and ABNF definitions to exclude "inputs"
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| types/index.d.ts | Removed "inputs" from the ComponentsExpression field type union |
| test/fixtures/expressions-valid.js | Removed the invalid $components.inputs.username test case |
| src/grammar.js | Updated generated grammar opcodes and ABNF string to remove "inputs" option |
| src/grammar.bnf | Updated BNF grammar definition to remove "inputs" from components-field rule |
| README.md | Updated grammar documentation to remove "inputs" from components-field rule |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
char0n
pushed a commit
that referenced
this pull request
Jan 29, 2026
Member
Author
|
🎉 This PR is included in version 2.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"inputs" field is not allowed.