Skip to content

fix: catch JSONDecode error and provide response from api #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nirmalalla wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: catch JSONDecode error and provide response from api #657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/nba_api/library/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,16 @@ def get_response(self):
return self._response

def get_dict(self):
return json.loads(self._response)
try:
return json.loads(self._response)
except json.JSONDecodeError as e:
preview = (self._response or "")[:300].strip()
raise ValueError(
f"""
Failed to parse NBA API response as JSON.\n
Response preview (first 300 chars): {preview!r}
"""
) from e

def get_json(self):
return json.dumps(self.get_dict())
Expand Down