refactor(tigrbl): move ValidityWindow mixin from fields to lifecycle#4972
Open
cobycloud wants to merge 2 commits into
Open
refactor(tigrbl): move ValidityWindow mixin from fields to lifecycle#4972cobycloud wants to merge 2 commits into
cobycloud wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ValidityWindowmixin out offields.pyand intolifecycle.pyso semantics align with other timestamp/version mixins.Description
ValidityWindow@declarative_mixin(withvalid_from/valid_tocolumn specs usingtzutcnow/tzutcnow_plus_day) frompkgs/standards/tigrbl/tigrbl/orm/mixins/fields.pytopkgs/standards/tigrbl/tigrbl/orm/mixins/lifecycle.pywithout changing the column behavior.tzutcnow_plus_dayimport tolifecycle.pyand removed now-unused datetime- and TZ-related imports fromfields.py.pkgs/standards/tigrbl/tigrbl/orm/mixins/__init__.pyto importValidityWindowfrom.lifecycleand removed it from the.fieldsimport list while preserving the public__all__surface.Testing
ruff format .inpkgs/standards/tigrbl, which succeeded and reformatted 1 file.ruff check . --fixinpkgs/standards/tigrbl, which succeeded and auto-fixed 2 issues.uv run --directory standards --package tigrbl ruff format .frompkgs/, which failed due to the workspace/source configuration preventing dependency resolution in this environment.Codex Task