Add support for Clojure metadata#95
Open
dgshep wants to merge 1 commit into
Open
Conversation
dgshep
commented
May 13, 2026
| def __eq__(self, other): | ||
| if not isinstance(other, MetadataValue): | ||
| return False | ||
| return self.metadata == other.metadata and self.value == other.value |
Author
There was a problem hiding this comment.
On the one hand: this doesn't match Clojure's semantics for equality. However, for testing equality between parsed representations, not having this is rather painful. I'm open to suggestions on this one.
There was a problem hiding this comment.
FWIW edn-ruby opted to follow Clojure's semantics - see this test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While metadata isn't part of the core EDN spec, it is implemented in the Clojure reader and implemented in other edn handline libraries (e.g. edn-ruby)
This PR adds first-class support for serializing/parsing MetadataValue objects as clojure reader metadata
^{metadata} value