fix: babel plugin not being configured properly for ts

Author: swashata

packages/eslint-config/config/rules.js

@@ -11,7 +11,6 @@ module.exports = {
 			allowForLoopAfterthoughts: true,
 		},
 	],
-	camelcase: 'off',
 	'react/jsx-filename-extension': 'off',
 	'react-hooks/rules-of-hooks': 'error',
 	'react-hooks/exhaustive-deps': 'warn',
@@ -23,4 +22,55 @@ module.exports = {
 	'func-names': 'off',
 	'lines-between-class-members': 'off',
 	'import/extensions': ['error', 'never'],
+	// ===================================
+	// Some rules from eslint-plugin-babel
+	// ===================================
+	// First turn them off
+	'new-cap': 'off',
+	camelcase: 'off',
+	'no-invalid-this': 'off',
+	'object-curly-spacing': 'off',
+	semi: 'off',
+	'no-unused-expressions': 'off',
+	'valid-typeof': 'off',
+	// require a capital letter for constructors
+	'babel/new-cap': [
+		'error',
+		{
+			newIsCap: true,
+			newIsCapExceptions: [],
+			capIsNew: false,
+			capIsNewExceptions: ['Immutable.Map', 'Immutable.Set', 'Immutable.List'],
+		},
+	],
+	// require camel case names
+	// This one is enhanced from airbnb and accounts for destructuring
+	// and react UNSAFE_component* methods.
+	'babel/camelcase': [
+		'error',
+		{
+			properties: 'never',
+			ignoreDestructuring: true,
+		},
+	],
+	// We would force invalid this rules
+	// But would only warn about it
+	'babel/no-invalid-this': 'warn',
+	// We don't configure curly spacing because of prettier
+	'babel/object-curly-spacing': 'off',
+	// We don't configure babel/semi because of prettier
+	'babel/semi': 'off',
+	// disallow usage of expressions in statement position
+	'babel/no-unused-expressions': [
+		'error',
+		{
+			allowShortCircuit: false,
+			allowTernary: false,
+			allowTaggedTemplates: false,
+		},
+	],
+	// ensure that the results of typeof are compared against a valid string
+	// https://eslint.org/docs/rules/valid-typeof
+	'babel/valid-typeof': ['error', { requireStringLiterals: true }],
+	'no-unused-vars': 'warn',
 };

packages/eslint-config/index.js

@@ -23,60 +23,5 @@ module.exports = {
 	plugins: ['babel', 'react-hooks'],
 	rules: {
 		...rules,
-		// ===================================
-		// Some rules from eslint-plugin-babel
-		// ===================================
-		// First turn them off
-		'new-cap': 'off',
-		camelcase: 'off',
-		'no-invalid-this': 'off',
-		'object-curly-spacing': 'off',
-		semi: 'off',
-		'no-unused-expressions': 'off',
-		'valid-typeof': 'off',
-		// require a capital letter for constructors
-		'babel/new-cap': [
-			'error',
-			{
-				newIsCap: true,
-				newIsCapExceptions: [],
-				capIsNew: false,
-				capIsNewExceptions: [
-					'Immutable.Map',
-					'Immutable.Set',
-					'Immutable.List',
-				],
-			},
-		],
-		// require camel case names
-		// This one is enhanced from airbnb and accounts for destructuring
-		// and react UNSAFE_component* methods.
-		'babel/camelcase': [
-			'error',
-			{
-				properties: 'never',
-				ignoreDestructuring: true,
-			},
-		],
-		// We would force invalid this rules
-		// But would only warn about it
-		'babel/no-invalid-this': 'warn',
-		// We don't configure curly spacing because of prettier
-		'babel/object-curly-spacing': 'off',
-		// We don't configure babel/semi because of prettier
-		'babel/semi': 'off',
-		// disallow usage of expressions in statement position
-		'babel/no-unused-expressions': [
-			'error',
-			{
-				allowShortCircuit: false,
-				allowTernary: false,
-				allowTaggedTemplates: false,
-			},
-		],
-		// ensure that the results of typeof are compared against a valid string
-		// https://eslint.org/docs/rules/valid-typeof
-		'babel/valid-typeof': ['error', { requireStringLiterals: true }],
-		'no-unused-vars': 'warn',
 	},
 };

packages/scripts/.eslintrc.js

@@ -5,7 +5,7 @@ module.exports = {
 			files: ['**/*.ts', '**/*.tsx'],
 			extends: ['@wpackio/eslint-config/ts'],
 			parserOptions: {
-				project: './tsconfig.json',
+				project: './tsconfig.eslint.json',
 				tsconfigRootDir: __dirname,
 			},
 			settings: {
@@ -17,6 +17,8 @@ module.exports = {
 			},
 			rules: {
 				'no-console': 'off',
+				'jest/no-conditional-expect': 'off',
+				'@typescript-eslint/ban-ts-comment': 'off',
 			},
 		},
 	],

site/docs/guides/changelog.md

@@ -6,9 +6,15 @@ shortTitle: Changelog
 
 ## VERSION 6.3.0
 
+#### `@wpackio/scripts`
+
 - **NEW** Option `useBabelConfig` in file config to override project-wide configuration for a particular entry.
 - **NEW** Option `compileNodeModules` in project config to handle how `node_modules` are compiled during production and development.
 
+#### `@wpackio/eslint-config`
+
+- **FIX** Babel plugin not being configured properly for typescript preset.
+
 ---
 
 For previous changelogs, kindly visit our [GitHub Repo](https://github.com/swashata/wp-webpack-script/blob/master/CHANGELOG.md).