fix(graphql-codegen-client-preset): support namingConvention object and keep mode (#593)

Author: kdy1

contrib/graphql-codegen-client-preset/src/lib.rs

@@ -83,8 +83,12 @@ fn to_pascal_case(s: &str) -> String {
 
 fn apply_naming_convention(s: &str, naming_convention: &str) -> String {
     match naming_convention {
+        "change-case-all#pascalCase" => to_pascal_case(s),
         "change-case-all#upperCaseFirst" => upper_case_first(s),
-        _ => to_pascal_case(s),
+        // GraphQL Codegen supports `keep`; preserve casing in that mode.
+        "keep" => s.to_string(),
+        // Keep unknown/custom conventions unchanged instead of forcing PascalCase.
+        _ => s.to_string(),
     }
 }
 
@@ -340,6 +344,30 @@ fn naming_convention_default() -> String {
     "change-case-all#pascalCase".to_string()
 }
 
+#[derive(Deserialize)]
+#[serde(untagged)]
+enum NamingConventionOption {
+    String(String),
+    Object(serde_json::Value),
+}
+
+impl NamingConventionOption {
+    fn as_type_name_convention(&self) -> String {
+        match self {
+            NamingConventionOption::String(v) => v.to_string(),
+            NamingConventionOption::Object(v) => v
+                .get("typeNames")
+                .and_then(|t| t.as_str())
+                .map(str::to_string)
+                .unwrap_or_else(naming_convention_default),
+        }
+    }
+}
+
+fn naming_convention_option_default() -> NamingConventionOption {
+    NamingConventionOption::String(naming_convention_default())
+}
+
 #[allow(non_snake_case)]
 #[derive(Deserialize)]
 struct PluginOptions {
@@ -348,8 +376,8 @@ struct PluginOptions {
     #[serde(default = "gql_default")]
     gqlTagName: String,
 
-    #[serde(default = "naming_convention_default")]
-    namingConvention: String,
+    #[serde(default = "naming_convention_option_default")]
+    namingConvention: NamingConventionOption,
 }
 
 #[plugin_transform]
@@ -380,7 +408,7 @@ pub fn process_transform(program: Program, metadata: TransformPluginProgramMetad
         cwd,
         artifact_directory,
         gql_tag_name: plugin_config.gqlTagName,
-        naming_convention: plugin_config.namingConvention,
+        naming_convention: plugin_config.namingConvention.as_type_name_convention(),
     });
 
     program.apply(&mut visit_mut_pass(visitor))

contrib/graphql-codegen-client-preset/src/tests.rs

@@ -210,3 +210,54 @@ const SomeEGRockets = gql(`
   }
 `);"#
 );
+
+#[test]
+fn naming_convention_keep_preserves_original_name() {
+    assert_eq!(
+        apply_naming_convention("SomeEGRocketsDocument", "keep"),
+        "SomeEGRocketsDocument"
+    );
+}
+
+#[test]
+fn naming_convention_unknown_preserves_original_name() {
+    assert_eq!(
+        apply_naming_convention("SomeEGRocketsDocument", "lodash#camelCase"),
+        "SomeEGRocketsDocument"
+    );
+}
+
+#[test]
+fn plugin_options_accept_object_naming_convention() {
+    let options: PluginOptions = serde_json::from_str(
+        r#"{
+            "artifactDirectory":"./src/gql",
+            "namingConvention":{
+                "typeNames":"keep",
+                "enumValues":"change-case-all#upperCaseFirst",
+                "transformUnderscore":true
+            }
+        }"#,
+    )
+    .unwrap();
+
+    assert_eq!(options.namingConvention.as_type_name_convention(), "keep");
+}
+
+#[test]
+fn plugin_options_object_without_type_names_uses_default_naming_convention() {
+    let options: PluginOptions = serde_json::from_str(
+        r#"{
+            "artifactDirectory":"./src/gql",
+            "namingConvention":{
+                "enumValues":"keep"
+            }
+        }"#,
+    )
+    .unwrap();
+
+    assert_eq!(
+        options.namingConvention.as_type_name_convention(),
+        "change-case-all#pascalCase"
+    );
+}