fix(formatjs): scope static evaluation to formatjs descriptor keys only

[kdy1]

Two bugs caused valid JSX outside formatjs calls to trigger the "must be statically evaluate-able" error:

1. visit_mut_jsx_opening_element only guarded against JSXElementName::Ident names. Member expressions like React.Suspense fell through the guard and had their attributes (e.g. fallback={<Loading />}) evaluated, causing spurious errors.

2. JSXAttrOrSpread::get_key_value_with_visitor called evaluate_expr for ALL JSXExprContainer attribute values regardless of the attribute key. Attributes like values or fallback that contain JSX expressions would trigger the error even inside legitimate FormattedMessage components.

Fixes #588

Generated with Claude Code

[changeset-bot]

⚠️ No Changeset found

Latest commit: d1a0294

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[claude]

PR Review: fix(formatjs): scope static evaluation to formatjs descriptor keys only

This PR fixes two related bugs that caused spurious "must be statically evaluate-able" errors on valid JSX outside of formatjs calls. The fixes are well-targeted and minimal.

Bug Fix 1: visit_mut_jsx_opening_element (lib.rs:986)

Correct fix. The original if let JSXElementName::Ident(ident) = name pattern only returned early for simple identifiers not in component_names — member expressions like React.Suspense silently fell through and had their attributes processed. The new match with _ => return properly guards all non-Ident variants (JSXMemberExpr, JSXNamespacedName).

Bug Fix 2: get_key_value_with_visitor (lib.rs:91)

Correct fix. The refactor from Some(name.sym.to_string()) to a plain String is sound since the match arms are exhaustive — key was always Some(...). The new guard:

if !matches!(key.as_str(), "id" | "defaultMessage" | "description") {
    return None;
}

correctly restricts static evaluation to the three known formatjs message descriptor fields. Attributes like values or fallback that may contain JSX are now skipped, preventing false errors.

Nit: hardcoded descriptor keys

The list "id" | "defaultMessage" | "description" is correct per the formatjs spec. If the plugin already has a constant or enum for these elsewhere, it might be worth referencing that rather than a literal match — but this is a minor style point and the current approach is clear.

Tests

All three added test cases directly cover the reported scenarios from #588:

1. React.Suspense with a JSX fallback prop
2. Conditional JSX expressions in unrelated components
3. FormattedMessage with a values prop containing JSX

Suggestion: Consider also adding a positive test that confirms the plugin still correctly extracts and transforms id/defaultMessage/description when they contain valid string literals inside a known formatjs component. This would guard against accidentally over-filtering in the future.

Changeset

The changeset-bot flagged that no changeset was added. Since this is a user-visible bug fix, a patch changeset for @swc/plugin-formatjs is likely needed (the bot already provides a pre-filled link in its comment).

---

Overall: the root cause analysis is accurate, the fixes are minimal and correct, and the tests are well-chosen. Good work.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d1a0294c82

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Support member-expression message components

visit_mut_jsx_opening_element now returns for every non-Ident tag, which fixes React.Suspense but also skips valid message components written as member expressions, e.g. import * as ReactIntl from 'react-intl'; <ReactIntl.FormattedMessage defaultMessage="..." />. Before this change those nodes still reached create_message_descriptor_from_extractor; with the new early return they never get IDs generated, descriptions removed, or messages extracted. This affects projects that use namespace imports or object-qualified wrapper components.

Useful? React with 👍 / 👎.