fix(loadable-components): skip transformation when ssr: false is specified

[kdy1]

When loadable() is called with { ssr: false } in the options object, the plugin now skips the SSR transformation as required by the loadable-components API.

Fixes #465

Generated with Claude Code

[changeset-bot]

⚠️ No Changeset found

Latest commit: af29599

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[claude]

Code Review

Overall this is a clean, correct fix for issue #465. The implementation is straightforward and well-targeted. A few observations:

Correctness

The logic in has_ssr_false correctly handles:

• Missing second argument → skip (return false, don't skip transform)
• Non-object second argument → don't skip
• ssr key as both Ident and Str variants — good coverage
• Spread properties are safely ignored (falls through to false)

One edge case worth considering: computed property keys like { ["ssr"]: false }. The current implementation only matches PropName::Ident and PropName::Str, so { ["ssr"]: false } would not be detected. This is likely fine in practice (uncommon pattern), but worth a comment or test if the reference Babel plugin handles it.

Missing changeset

The changeset-bot flagged that there's no changeset file. Since this is a bug fix that changes observable behavior, a .changeset file should be added so a patch version bump is issued for @swc/plugin-loadable-components.

Test coverage

The added test covers the basic case well. Consider adding tests for:

1. { ssr: true } — should still transform (regression guard)
2. { ssr: false } using a string key { "ssr": false } — exercises the PropName::Str branch
3. loadable.lib(() => import("./Foo"), { ssr: false }) — verifies the skip also applies for the .lib call pattern if applicable

Minor style note

The intermediate is_ssr_key binding is clear and readable. Alternatively it could be folded directly into the matches! macro condition, but the current form is arguably more readable — no change needed.

Summary

The implementation is correct and the approach is appropriate. The main actionable items are:

• Add a .changeset entry for the patch bump
• Optionally add a { ssr: true } fixture to guard against regressions

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: af29599f5f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Respect later overrides when checking ssr: false

has_ssr_false() now returns true if any property in the options object is ssr: false, but JavaScript object literals are order-sensitive. Inputs like loadable(() => import('./Comp'), { ssr: false, ...opts }) or { ssr: false, ssr: true } end up with ssr !== false at runtime, yet this branch still skips the transform entirely. In those cases we silently drop the loadable SSR metadata even though SSR is effectively enabled.

Useful? React with 👍 / 👎.